Missing map shapes in summary step #791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the geoJsonGeometry is available before the featureGroupRef is set, can the useEffect hook not draw the map shapes
Bundle ReportChanges will decrease total bundle size by 20 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
==========================================
+ Coverage 83.67% 83.68% +0.01%
==========================================
Files 244 244
Lines 4777 4780 +3
Branches 1268 1269 +1
==========================================
+ Hits 3997 4000 +3
Misses 747 747
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| }, | ||
| // `featureGroupRef.current` is needed as dependency to make sure that | ||
| // the featureGroupRef can be used. | ||
| [geoJsonGeometry, featureGroupRef.current] |
There was a problem hiding this comment.
Can you check these linter warnings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-formulieren/open-forms#5038
Because the geoJsonGeometry is available before the featureGroupRef is set, can the useEffect hook not draw the map shapes.
This fix makes sure that featureGroupRef is set, so that map shapes can be drawn